[asterisk-dev] [Code Review] 2902: Make app_queue and res_agi independent of AMI being enabled.

svnbot reviewboard at asterisk.org
Tue Oct 8 10:11:06 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2902/
-----------------------------------------------------------

(Updated Oct. 8, 2013, 3:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 400671


Bugs: ASTERISK-22604
    https://issues.asterisk.org/jira/browse/ASTERISK-22604


Repository: Asterisk


Description
-------

The https://reviewboard.asterisk.org/r/2888/ review changes manager to not subscribe to stasis when it is disabled for performance reasons.  When manager is disabled app_queue and res_agi decline to load and fail to clean up what they have already allocated.

* Made app_queue and res_agi clean up allocated resources when they decline to load.

* Made app_queue and res_agi use their own subscriptions to the stasis topics instead of borrowing manager's message router structure inappropriately.


Diffs
-----

  /branches/12/apps/app_queue.c 400593 
  /branches/12/res/res_agi.c 400593 

Diff: https://reviewboard.asterisk.org/r/2902/diff/


Testing
-------

* app_queue and res_agi now load when manager is disabled.
* The AMI events are generated whenever manager is enabled.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131008/d15c1ef4/attachment-0001.html>


More information about the asterisk-dev mailing list