[asterisk-dev] [Code Review] 2902: Make app_queue and res_agi independent of AMI being enabled.

[rmudgett]

> On Oct. 7, 2013, 10:13 p.m., opticron wrote:
> > /branches/12/apps/app_queue.c, line 10639
> > <https://reviewboard.asterisk.org/r/2902/diff/1/?file=47025#file47025line10639>
> >
> >     Might as well fix this to be AST_MODULE_LOAD_DECLINE as well.

res value is not returned by load_module().  It is used as a cumulative error condition.  Renamed res to err instead.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2902/#review9902
-----------------------------------------------------------


On Oct. 5, 2013, 1:30 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2902/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 1:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22604
>     https://issues.asterisk.org/jira/browse/ASTERISK-22604
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The https://reviewboard.asterisk.org/r/2888/ review changes manager to not subscribe to stasis when it is disabled for performance reasons.  When manager is disabled app_queue and res_agi decline to load and fail to clean up what they have already allocated.
> 
> * Made app_queue and res_agi clean up allocated resources when they decline to load.
> 
> * Made app_queue and res_agi use their own subscriptions to the stasis topics instead of borrowing manager's message router structure inappropriately.
> 
> 
> Diffs
> -----
> 
>   /branches/12/apps/app_queue.c 400593 
>   /branches/12/res/res_agi.c 400593 
> 
> Diff: https://reviewboard.asterisk.org/r/2902/diff/
> 
> 
> Testing
> -------
> 
> * app_queue and res_agi now load when manager is disabled.
> * The AMI events are generated whenever manager is enabled.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131007/db6863c6/attachment.html>