[asterisk-dev] [Code Review] 2660: Add IPv6 Support To chan_iax2

[Michael Young]

> On Oct. 4, 2013, 10:48 a.m., opticron wrote:
> > /trunk/channels/chan_iax2.c, line 12680
> > <https://reviewboard.asterisk.org/r/2660/diff/3/?file=46956#file46956line12680>
> >
> >     Why not ::?

I believe that chan_sip defaults to 0.0.0.0, so that is what I put here.

(we discussed this on IRC but just in case we look back at this review and wonder why)


> On Oct. 4, 2013, 10:48 a.m., opticron wrote:
> > /trunk/main/features_config.c, line 1381
> > <https://reviewboard.asterisk.org/r/2660/diff/3/?file=46962#file46962line1381>
> >
> >     Unrelated change?

Yep, sorry about that... this was accidentally included in the patch.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2660/#review9886
-----------------------------------------------------------


On Oct. 3, 2013, 4:17 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2660/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 4:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22025
>     https://issues.asterisk.org/jira/browse/ASTERISK-22025
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability to bind and communicate over IPv6 addresses using chan_iax2.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 400443 
>   /trunk/channels/chan_iax2.c 400443 
>   /trunk/channels/iax2/include/iax2.h 400443 
>   /trunk/channels/iax2/include/parser.h 400443 
>   /trunk/channels/iax2/parser.c 400443 
>   /trunk/include/asterisk/acl.h 400443 
>   /trunk/main/acl.c 400443 
>   /trunk/main/features_config.c 400443 
>   /trunk/main/netsock.c 400443 
> 
> Diff: https://reviewboard.asterisk.org/r/2660/diff/
> 
> 
> Testing
> -------
> 
> Successfully made calls using iax2 over IPv6 between two dev machines.  SIP Softphone -> dev vm (iax2 ipv6) -> (iax2 ipv6) dev box -> SIP ITSP -> mobile phone
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131004/949de33e/attachment.html>