[asterisk-dev] [Code Review] 2660: Add IPv6 Support To chan_iax2

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2660/#review9886
-----------------------------------------------------------



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19096>

    There is no need for this forward declaration.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19106>

    inaddrcmp checks port as well.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19097>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19098>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19099>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19100>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19101>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19102>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19107>

    inaddrcmp checks port as well.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19108>

    inaddrcmp checks port as well.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19103>

    Red blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19109>

    inaddrcmp checks port as well.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19104>

    Why not ::?



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2660/#comment19105>

    The ast_strdupa is unnecessary since you're only using it immediately.



/trunk/channels/iax2/parser.c
<https://reviewboard.asterisk.org/r/2660/#comment19091>

    Red blob.



/trunk/channels/iax2/parser.c
<https://reviewboard.asterisk.org/r/2660/#comment19093>

    This will result in the length always being set to the full size of the ss member which may not be correct. In the address append function above, the length is encoded in the IE and is available in the variable len. The amount of data copied should be len as well.



/trunk/include/asterisk/acl.h
<https://reviewboard.asterisk.org/r/2660/#comment19094>

    This is a generic ast_sockaddr function and should live in netsock2.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2660/#comment19095>

    Unrelated change?


- opticron


On Oct. 3, 2013, 3:17 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2660/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 3:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22025
>     https://issues.asterisk.org/jira/browse/ASTERISK-22025
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability to bind and communicate over IPv6 addresses using chan_iax2.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 400443 
>   /trunk/channels/chan_iax2.c 400443 
>   /trunk/channels/iax2/include/iax2.h 400443 
>   /trunk/channels/iax2/include/parser.h 400443 
>   /trunk/channels/iax2/parser.c 400443 
>   /trunk/include/asterisk/acl.h 400443 
>   /trunk/main/acl.c 400443 
>   /trunk/main/features_config.c 400443 
>   /trunk/main/netsock.c 400443 
> 
> Diff: https://reviewboard.asterisk.org/r/2660/diff/
> 
> 
> Testing
> -------
> 
> Successfully made calls using iax2 over IPv6 between two dev machines.  SIP Softphone -> dev vm (iax2 ipv6) -> (iax2 ipv6) dev box -> SIP ITSP -> mobile phone
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131004/28d0c3df/attachment-0001.html>