[asterisk-dev] [Code Review] 2889: core: Reduce channel snapshotting and publishing.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2889/#review9869
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Sept. 28, 2013, 3:50 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2889/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 3:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently many core operations implicitly create and publish a snapshot of the channel they are acting on. If you perform many of these operations together they each do this, which is wasteful. The attached patch adds the ability to mark a channel as staging a snapshot so the operations do not create and publish a snapshot. Once all operations are completed the staging is marked as done, and THEN the snapshot goes out. This reduces channel snapshotting and publishing by an average of 50% on channel creation, origination, and hangup.
> 
> 
> Diffs
> -----
> 
>   /branches/12/apps/app_dial.c 399908 
>   /branches/12/channels/chan_alsa.c 399908 
>   /branches/12/channels/chan_console.c 399908 
>   /branches/12/channels/chan_dahdi.c 399908 
>   /branches/12/channels/chan_gtalk.c 399908 
>   /branches/12/channels/chan_iax2.c 399908 
>   /branches/12/channels/chan_jingle.c 399908 
>   /branches/12/channels/chan_mgcp.c 399908 
>   /branches/12/channels/chan_motif.c 399908 
>   /branches/12/channels/chan_pjsip.c 399908 
>   /branches/12/channels/chan_sip.c 399908 
>   /branches/12/channels/chan_skinny.c 399908 
>   /branches/12/channels/chan_unistim.c 399908 
>   /branches/12/channels/sig_pri.c 399908 
>   /branches/12/channels/sig_ss7.c 399908 
>   /branches/12/include/asterisk/channel.h 399908 
>   /branches/12/include/asterisk/stasis_channels.h 399908 
>   /branches/12/main/bridge.c 399908 
>   /branches/12/main/channel.c 399908 
>   /branches/12/main/dial.c 399908 
>   /branches/12/main/pbx.c 399908 
>   /branches/12/main/stasis_channels.c 399908 
> 
> Diff: https://reviewboard.asterisk.org/r/2889/diff/
> 
> 
> Testing
> -------
> 
> Ran stuff, confirmed snapshots still go out.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131002/fa801f20/attachment-0001.html>