[asterisk-dev] [Code Review] 3017: PickupChan: Add ability to specify channel uniqueids as well as channel names.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3017/#review10233
-----------------------------------------------------------

Ship it!


- Joshua Colp


On Nov. 18, 2013, 9:25 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3017/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 9:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Made PickupChan() search by channel uniqueids if the search could not find a channel by name.
> 
> * Ensured PickupChan() never considers the picking channel for pickup.
> 
> * Made PickupChan() option p use a common search by name routine.  The original search was erroneously case sensitive.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_directed_pickup.c 402883 
>   /trunk/CHANGES 402883 
> 
> Diff: https://reviewboard.asterisk.org/r/3017/diff/
> 
> 
> Testing
> -------
> 
> Picked up channels by name and uniqueid.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/4ca85810/attachment.html>