[asterisk-dev] [Code Review] 3017: PickupChan: Add ability to specify channel uniqueids as well as channel names.

rmudgett reviewboard at asterisk.org
Mon Nov 18 15:25:39 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3017/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 9:25 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed comments and made the PickupChan p option also check uniqueids.


Repository: Asterisk


Description
-------

* Made PickupChan() search by channel uniqueids if the search could not find a channel by name.

* Ensured PickupChan() never considers the picking channel for pickup.

* Made PickupChan() option p use a common search by name routine.  The original search was erroneously case sensitive.


Diffs (updated)
-----

  /trunk/apps/app_directed_pickup.c 402883 
  /trunk/CHANGES 402883 

Diff: https://reviewboard.asterisk.org/r/3017/diff/


Testing
-------

Picked up channels by name and uniqueid.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131118/30b4aa60/attachment.html>


More information about the asterisk-dev mailing list