[asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

Kevin Harwell reviewboard at asterisk.org
Thu Nov 7 17:17:10 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 7, 2013, 5:17 p.m.)

Review request for Asterisk Developers.


Addressed review findings:

Added the ability to have rules that are checked when adding and/or removing channels to/from a bridge.  Also command functions now return an integer value that can be descriptive of what kind of problems, if any, occurred before or during execution.

Bugs: ASTERISK-22624

Repository: Asterisk


Added a channel recording flag that is checked before adding a channel to a bridge.  If the the channel is currently being recorded a "409 Conflict" is returned and the channel is not added to the bridge.

Diffs (updated)

  branches/12/rest-api/api-docs/bridges.json 402536 
  branches/12/res/stasis/control.c 402536 
  branches/12/res/stasis/command.c 402536 
  branches/12/res/stasis/command.h 402536 
  branches/12/res/res_stasis_recording.c 402536 
  branches/12/res/res_stasis_playback.c 402536 
  branches/12/res/res_stasis_answer.c 402536 
  branches/12/res/ari/resource_bridges.c 402536 
  branches/12/include/asterisk/stasis_app_impl.h 402536 
  branches/12/include/asterisk/stasis_app.h 402536 

Diff: https://reviewboard.asterisk.org/r/2947/diff/


Ran a manual test and also wrote a testsuite test: https://reviewboard.asterisk.org/r/2951/


Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131107/7f7fb787/attachment.html>

More information about the asterisk-dev mailing list