<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2947/">https://reviewboard.asterisk.org/r/2947/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>


<p style="color: grey;"><i>Updated Nov. 7, 2013, 5:17 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed review findings:

Added the ability to have rules that are checked when adding and/or removing channels to/from a bridge.  Also command functions now return an integer value that can be descriptive of what kind of problems, if any, occurred before or during execution.</pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22624">ASTERISK-22624</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a channel recording flag that is checked before adding a channel to a bridge.  If the the channel is currently being recorded a "409 Conflict" is returned and the channel is not added to the bridge.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran a manual test and also wrote a testsuite test: https://reviewboard.asterisk.org/r/2951/</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/rest-api/api-docs/bridges.json <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/stasis/control.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/stasis/command.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/stasis/command.h <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/res_stasis_recording.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/res_stasis_playback.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/res_stasis_answer.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/res/ari/resource_bridges.c <span style="color: grey">(402536)</span></li>

 <li>branches/12/include/asterisk/stasis_app_impl.h <span style="color: grey">(402536)</span></li>

 <li>branches/12/include/asterisk/stasis_app.h <span style="color: grey">(402536)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2947/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>