[asterisk-dev] [Code Review] 2998: Push Security Events over AMI

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2998/#review10130
-----------------------------------------------------------


Excellent work on this one!

I would suggest making a modification to the manager.conf.sample file and CHANGES file to indicate that the "security" class of events has been added.


/branches/12/include/asterisk/security_events.h
<https://reviewboard.asterisk.org/r/2998/#comment19403>

    The name of this function is a bit on the awkward side. Why is it called this?



/branches/12/main/security_events.c
<https://reviewboard.asterisk.org/r/2998/#comment19402>

    This should not be required.


- Mark Michelson


On Nov. 6, 2013, 5:54 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2998/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 5:54 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds a to AMI handler for security event messages. I'm not 100% sure if it's proper to initialize the message forwarder in a secondary initialization step like I am, but I wasn't sure if I should move the initialization of the entire security event framework to after manager initializes instead.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/security_events.c 402500 
>   /branches/12/main/manager.c 402500 
>   /branches/12/main/asterisk.c 402500 
>   /branches/12/include/asterisk/security_events.h 402500 
>   /branches/12/include/asterisk/manager.h 402500 
> 
> Diff: https://reviewboard.asterisk.org/r/2998/diff/
> 
> 
> Testing
> -------
> 
> Tested that security events get logged over AMI.  Tested that obvious memory leaks against strings and the security event system aren't occurring with MALLOC_DEBUG.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131106/df773709/attachment.html>