[asterisk-dev] [Code Review] 2998: Push Security Events over AMI

jrose reviewboard at asterisk.org
Wed Nov 6 11:54:46 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 6, 2013, 5:54 p.m.)

Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.


Minor spacing change added

Repository: Asterisk


Adds a to AMI handler for security event messages. I'm not 100% sure if it's proper to initialize the message forwarder in a secondary initialization step like I am, but I wasn't sure if I should move the initialization of the entire security event framework to after manager initializes instead.

Diffs (updated)

  /branches/12/main/security_events.c 402500 
  /branches/12/main/manager.c 402500 
  /branches/12/main/asterisk.c 402500 
  /branches/12/include/asterisk/security_events.h 402500 
  /branches/12/include/asterisk/manager.h 402500 

Diff: https://reviewboard.asterisk.org/r/2998/diff/


Tested that security events get logged over AMI.  Tested that obvious memory leaks against strings and the security event system aren't occurring with MALLOC_DEBUG.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131106/d4c8e5ef/attachment-0001.html>

More information about the asterisk-dev mailing list