[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

Kevin Harwell reviewboard at asterisk.org
Fri Nov 1 13:24:11 CDT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 1, 2013, 1:24 p.m.)

Review request for Asterisk Developers.


Addressed most of the review findings.  Also split up the "active_channels_to_str" to hopefully make some items more reusable.

Bugs: ASTERISK-22609

Repository: Asterisk


Created the following AMI commands and corresponding events for res_pjsip:

PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select attributes on each.
    EndpointList - for each endpoint a few attributes
    EndpointlistComplete - after all endpoints have been listed

PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
    EndpointDetail - attributes on an endpoint
    AorDetail - raised for each AOR on an endpoint
    AuthDetail - raised for each associated inbound and outbound auth
    TransportDetail - transport attributes
    IdentifyDetail - attributes for the identify object associated with the endpoint
    EndpointDetailComplete - last event raised after all detail events

PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound registrations
    InboundRegistrationDetail - inbound registration attributes for each registration
    InboundRegistrationDetailComplete - raised after all detail records have been listed

PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound registrations
    OutboundRegistrationDetail - outbound registration attributes for each registration
    OutboundRegistrationDetailComplete - raised after all detail records have been listed

PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
    SubscriptionDetail - on each subscription detailed attributes
    SubscriptionDetailComplete - raised after all detail records have been listed

Diffs (updated)

  branches/12/res/res_pjsip_registrar.c 402377 
  branches/12/res/res_pjsip_pubsub.c 402377 
  branches/12/res/res_pjsip_outbound_registration.c 402377 
  branches/12/res/res_pjsip_mwi.c 402377 
  branches/12/res/res_pjsip_exten_state.c 402377 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 402377 
  branches/12/res/res_pjsip/pjsip_configuration.c 402377 
  branches/12/res/res_pjsip/location.c 402377 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 402377 
  branches/12/res/res_pjsip/config_transport.c 402377 
  branches/12/res/res_pjsip/config_auth.c 402377 
  branches/12/res/res_pjsip.exports.in 402377 
  branches/12/res/res_pjsip.c 402377 
  branches/12/main/utils.c 402377 
  branches/12/main/sorcery.c 402377 
  branches/12/main/acl.c 402377 
  branches/12/include/asterisk/strings.h 402377 
  branches/12/include/asterisk/sorcery.h 402377 
  branches/12/include/asterisk/res_pjsip_pubsub.h 402377 
  branches/12/include/asterisk/res_pjsip.h 402377 
  branches/12/include/asterisk/acl.h 402377 

Diff: https://reviewboard.asterisk.org/r/2959/diff/


Ran a few manual tests over AMI and observed the output to make sure things look correct.  Also wrote some testsuite tests: https://reviewboard.asterisk.org/r/2958/


Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131101/75997201/attachment.html>

More information about the asterisk-dev mailing list