[asterisk-dev] [Code Review] 2574: Fixup hold/unhold with attended and blind transfers.

[rmudgett]

> On May 30, 2013, 3:57 p.m., opticron wrote:
> > /trunk/bridges/bridge_builtin_features.c, lines 390-422
> > <https://reviewboard.asterisk.org/r/2574/diff/1/?file=38788#file38788line390>
> >
> >     The bridge_channel could be unheld (unholded?) twice if the transfer fails.

Doing the unhold twice should not be a problem.  If the ast_bridge_impart() fails bad things have happened (malloc or thread could not be obtained).  I did it this way so the normal cases (incomplete, abort) would play the beeperr while the bridge was on hold.


> On May 30, 2013, 3:57 p.m., opticron wrote:
> > /trunk/include/asterisk/channel.h, lines 1160-1171
> > <https://reviewboard.asterisk.org/r/2574/diff/1/?file=38790#file38790line1160>
> >
> >     This would be better suited in stasis_channels.h with the other channel publishing functions.  You may also want to consider refactoring existing code to use this (some in app_userevent and the varset publisher at least).  If not, I'll take care of it when I see this commit go in.

Moved the function.  The refactoring is much farther than I want to go in this patch.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2574/#review8726
-----------------------------------------------------------


On May 29, 2013, 10:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2574/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 10:03 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Mark Michelson, and Jason Parker.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * DTMF attended and blind transfers have hold/unhold behavior restored.
> 
> * External attended and blind transfers unhold the transfered party when the transfer is initiated.
> 
> * Made prohibit blind transferring a bridge marked as masquerade only.  (ConfBridge bridges)
> 
> * Made running an application or playing a file inside a bridge post the hold/unhold messages if MOH is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_builtin_features.c 390103 
>   /trunk/include/asterisk/bridging.h 390103 
>   /trunk/include/asterisk/channel.h 390103 
>   /trunk/main/bridging.c 390103 
>   /trunk/main/channel.c 390103 
> 
> Diff: https://reviewboard.asterisk.org/r/2574/diff/
> 
> 
> Testing
> -------
> 
> * Hold/unhold now works with DTMF attended and blind transfers.
> 
> * SIP attended and blind transfers stop MOH when the transfers are initiated.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/95673ac9/attachment-0001.htm>