[asterisk-dev] [Code Review] 2574: Fixup hold/unhold with attended and blind transfers.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2574/#review8726
-----------------------------------------------------------



/trunk/bridges/bridge_builtin_features.c
<https://reviewboard.asterisk.org/r/2574/#comment17094>

    The bridge_channel could be unheld (unholded?) twice if the transfer fails.



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2574/#comment17095>

    This would be better suited in stasis_channels.h with the other channel publishing functions.  You may also want to consider refactoring existing code to use this (some in app_userevent and the varset publisher at least).  If not, I'll take care of it when I see this commit go in.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2574/#comment17097>

    I'd go ahead and move this function to stasis_channels.c as well.


- opticron


On May 29, 2013, 5:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2574/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 5:03 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Mark Michelson, and Jason Parker.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * DTMF attended and blind transfers have hold/unhold behavior restored.
> 
> * External attended and blind transfers unhold the transfered party when the transfer is initiated.
> 
> * Made prohibit blind transferring a bridge marked as masquerade only.  (ConfBridge bridges)
> 
> * Made running an application or playing a file inside a bridge post the hold/unhold messages if MOH is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_builtin_features.c 390103 
>   /trunk/include/asterisk/bridging.h 390103 
>   /trunk/include/asterisk/channel.h 390103 
>   /trunk/main/bridging.c 390103 
>   /trunk/main/channel.c 390103 
> 
> Diff: https://reviewboard.asterisk.org/r/2574/diff/
> 
> 
> Testing
> -------
> 
> * Hold/unhold now works with DTMF attended and blind transfers.
> 
> * SIP attended and blind transfers stop MOH when the transfers are initiated.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/1b72654d/attachment-0001.htm>