[asterisk-dev] [Code Review] 2573: res_parking: Recreate the 'Park' manager action in the new parking system

[jrose]

> On May 30, 2013, 4:14 p.m., opticron wrote:
> > /trunk/res/parking/parking_manager.c, line 567
> > <https://reviewboard.asterisk.org/r/2573/diff/1/?file=38787#file38787line567>
> >
> >     Channel2 is specified as required in the documentation.

Fixed.  Channel2 is no longer specified as required in the documentation (and it probably never should have been required in the first place).


> On May 30, 2013, 4:14 p.m., opticron wrote:
> > /trunk/res/parking/parking_manager.c, line 77
> > <https://reviewboard.asterisk.org/r/2573/diff/1/?file=38787#file38787line77>
> >
> >     I know this is what was already in existance, but something more descriptive than "Channel2" would be nice here.

Care to offer any suggestions? I can think of ReturnChannel, ComebackChannel, and Parker (though parker is misleading since it isn't the actual parker and it isn't treated as such).

Obviously the old option still has to be supported, but we can add an alias and change the documentation without much trouble.


> On May 30, 2013, 4:14 p.m., opticron wrote:
> > /trunk/include/asterisk/bridging.h, line 820
> > <https://reviewboard.asterisk.org/r/2573/diff/1/?file=38784#file38784line820>
> >
> >     You should probably rename this function to be consistent with the rest of the code in this header. How about ast_bridge_add_channel?

Sounds good to me.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2573/#review8730
-----------------------------------------------------------


On May 29, 2013, 9:15 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2573/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 9:15 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21641
>     https://issues.asterisk.org/jira/browse/ASTERISK-21641
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch gets the 'Park' manager action back up and working. It supports all the arguments to the old park manager action and seems to work in the same way.
> This patch also fixes an issue with the 'Bridge' manager action where channels yanked from two party bridges would leave the bridge up in spite of there being only one channel in the bridge at that point.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/bridging.h 389959 
>   /trunk/main/bridging.c 389959 
>   /trunk/main/features.c 389959 
>   /trunk/res/parking/parking_manager.c 389959 
> 
> Diff: https://reviewboard.asterisk.org/r/2573/diff/
> 
> 
> Testing
> -------
> 
> Pulled channels from bridged and unbridged calls with the 'Park' and made sure the channel on the other end got torn down in each case. I did similar stuff with the 'Bridge' command.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/e3f7064f/attachment.htm>