[asterisk-dev] [Code Review] 2573: res_parking: Recreate the 'Park' manager action in the new parking system

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2573/#review8730
-----------------------------------------------------------



/trunk/include/asterisk/bridging.h
<https://reviewboard.asterisk.org/r/2573/#comment17098>

    You should probably rename this function to be consistent with the rest of the code in this header. How about ast_bridge_add_channel?



/trunk/res/parking/parking_manager.c
<https://reviewboard.asterisk.org/r/2573/#comment17099>

    I know this is what was already in existance, but something more descriptive than "Channel2" would be nice here.



/trunk/res/parking/parking_manager.c
<https://reviewboard.asterisk.org/r/2573/#comment17100>

    Channel2 is specified as required in the documentation.


- opticron


On May 29, 2013, 4:15 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2573/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 4:15 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21641
>     https://issues.asterisk.org/jira/browse/ASTERISK-21641
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch gets the 'Park' manager action back up and working. It supports all the arguments to the old park manager action and seems to work in the same way.
> This patch also fixes an issue with the 'Bridge' manager action where channels yanked from two party bridges would leave the bridge up in spite of there being only one channel in the bridge at that point.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/bridging.h 389959 
>   /trunk/main/bridging.c 389959 
>   /trunk/main/features.c 389959 
>   /trunk/res/parking/parking_manager.c 389959 
> 
> Diff: https://reviewboard.asterisk.org/r/2573/diff/
> 
> 
> Testing
> -------
> 
> Pulled channels from bridged and unbridged calls with the 'Park' and made sure the channel on the other end got torn down in each case. I did similar stuff with the 'Bridge' command.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/fb12feca/attachment.htm>