[asterisk-dev] [Code Review] 2507: Add support for indexing installed sounds and for Stasis-HTTP sounds queries

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2507/
-----------------------------------------------------------

(Updated May 24, 2013, 2:02 p.m.)


Review request for Asterisk Developers and David Lee.


Changes
-------

Address comments. The media indexer has now been separated from the sounds indexer and everything is back in core.


Bugs: ASTERISK-21584 and ASTERISK-21585
    https://issues.asterisk.org/jira/browse/ASTERISK-21584
    https://issues.asterisk.org/jira/browse/ASTERISK-21585


Repository: Asterisk


Description
-------

This adds support for stasis/sounds and stasis/sounds/{ID} queries via the Stasis-HTTP interface.

The following changes have been made to accomplish this:
* A modular indexer was created for local sound files.
* A new function to get an ast_format associated with a file extension was added.  
* Modifications were made to the built-in HTTP server so that URI decoding could be deferred to the URI handler when necessary.
* The Stasis-HTTP sounds JSON documentation was modified to handle cases where multiple languages are installed in different formats.

This requires the additions to astobj2.c/h present in https://reviewboard.asterisk.org/r/2428/


Diffs (updated)
-----

  trunk/include/asterisk/_private.h 389730 
  trunk/include/asterisk/file.h 389730 
  trunk/include/asterisk/format.h 389730 
  trunk/include/asterisk/http.h 389730 
  trunk/include/asterisk/media_index.h PRE-CREATION 
  trunk/include/asterisk/sounds_index.h PRE-CREATION 
  trunk/main/asterisk.c 389730 
  trunk/main/file.c 389730 
  trunk/main/http.c 389730 
  trunk/main/media_index.c PRE-CREATION 
  trunk/main/sounds_index.c PRE-CREATION 
  trunk/res/res_stasis_http.c 389730 
  trunk/res/stasis_http/resource_sounds.c 389730 
  trunk/rest-api/api-docs/sounds.json 389730 

Diff: https://reviewboard.asterisk.org/r/2507/diff/


Testing
-------

Tested using a browser and HTTP GET requests using the Stasis-HTTP API.  Currently contemplating how to create automated tests.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130524/3a14c956/attachment.htm>