<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2507/">https://reviewboard.asterisk.org/r/2507/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Lee.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated May 24, 2013, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address comments. The media indexer has now been separated from the sounds indexer and everything is back in core.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21584">ASTERISK-21584</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21585">ASTERISK-21585</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds support for stasis/sounds and stasis/sounds/{ID} queries via the Stasis-HTTP interface.
The following changes have been made to accomplish this:
* A modular indexer was created for local sound files.
* A new function to get an ast_format associated with a file extension was added.
* Modifications were made to the built-in HTTP server so that URI decoding could be deferred to the URI handler when necessary.
* The Stasis-HTTP sounds JSON documentation was modified to handle cases where multiple languages are installed in different formats.
This requires the additions to astobj2.c/h present in https://reviewboard.asterisk.org/r/2428/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using a browser and HTTP GET requests using the Stasis-HTTP API. Currently contemplating how to create automated tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/include/asterisk/_private.h <span style="color: grey">(389730)</span></li>
<li>trunk/include/asterisk/file.h <span style="color: grey">(389730)</span></li>
<li>trunk/include/asterisk/format.h <span style="color: grey">(389730)</span></li>
<li>trunk/include/asterisk/http.h <span style="color: grey">(389730)</span></li>
<li>trunk/include/asterisk/media_index.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/include/asterisk/sounds_index.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/main/asterisk.c <span style="color: grey">(389730)</span></li>
<li>trunk/main/file.c <span style="color: grey">(389730)</span></li>
<li>trunk/main/http.c <span style="color: grey">(389730)</span></li>
<li>trunk/main/media_index.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/main/sounds_index.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_http.c <span style="color: grey">(389730)</span></li>
<li>trunk/res/stasis_http/resource_sounds.c <span style="color: grey">(389730)</span></li>
<li>trunk/rest-api/api-docs/sounds.json <span style="color: grey">(389730)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2507/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>