[asterisk-dev] [Code Review] 2559: Implement playback controls for Stasis-HTTP

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2559/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-21587
    https://issues.asterisk.org/jira/browse/ASTERISK-21587


Repository: Asterisk


Description
-------

This patch adds support for controlling a playback operation from the
Asterisk REST interface.

This adds the /playback/{playbackId}/control resource, which may be
POSTed to to pause, unpause, reverse, forward or restart the media
playback.

Attempts to control a playback that is not currently playing will
either return a 404 Not Found (because the playback object no longer
exists) or a 409 Conflict (because the playback object is still in the
queue to be played).

This patch also adds skipms and offsetms parameters to the
/channels/{channelId}/play resource.

(closes issue ASTERISK-21587)
Review: https://reviewboard.asterisk.org/r/2559


Diffs
-----

  /team/dlee/playback-rebase/include/asterisk/app.h 389484 
  /team/dlee/playback-rebase/include/asterisk/channel.h 389484 
  /team/dlee/playback-rebase/include/asterisk/stasis_app.h 389484 
  /team/dlee/playback-rebase/include/asterisk/stasis_app_playback.h 389484 
  /team/dlee/playback-rebase/main/app.c 389484 
  /team/dlee/playback-rebase/res/res_stasis_http_channels.c 389484 
  /team/dlee/playback-rebase/res/res_stasis_playback.c 389484 
  /team/dlee/playback-rebase/res/stasis/control.c 389484 
  /team/dlee/playback-rebase/res/stasis_http/resource_channels.h 389484 
  /team/dlee/playback-rebase/res/stasis_http/resource_channels.c 389484 
  /team/dlee/playback-rebase/res/stasis_http/resource_playback.c 389484 
  /team/dlee/playback-rebase/rest-api/api-docs/channels.json 389484 
  /team/dlee/playback-rebase/rest-api/api-docs/playback.json 389484 

Diff: https://reviewboard.asterisk.org/r/2559/diff/


Testing
-------

Used swagger-ui to poke the playback control resource.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130522/2c13528f/attachment.htm>