[asterisk-dev] [Code Review] 2551: Make ConfBridge use its own unreal announcer channel driver and delete chan_bridge.

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2551/
-----------------------------------------------------------

(Updated May 21, 2013, 11:54 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 389370


Bugs: ASTERISK-21271
    https://issues.asterisk.org/jira/browse/ASTERISK-21271


Repository: Asterisk


Description
-------

This is a fairly stand alone change on the way to making ConfBridge a subclass of ast_bridge.

* Made the ConfBridge recorder channel driver type name and channel name consistent.  Before the channel driver type was ConfBridgeRec and the created channel name was ConfBridgeRecorder/conf-%s-uid-%d.  Now it is CBRec and CBRec/conf-%s-uid-%d respectively.

* Replaced ConfBridge usage of chan_bridge with its own announcer channel.

* Deleted chan_bridge since it was created just for ConfBridge and it no longer uses it.

* The CBRec and CBAnn drivers set the recorder and announcer bridge channel roles respectively and are marked as IMMOVABLE to bridge merges and channel moves.


Diffs
-----

  /team/group/bridge_construction/apps/app_confbridge.c 389336 
  /team/group/bridge_construction/apps/confbridge/conf_chan_announce.c PRE-CREATION 
  /team/group/bridge_construction/apps/confbridge/conf_chan_record.c PRE-CREATION 
  /team/group/bridge_construction/apps/confbridge/include/confbridge.h 389336 
  /team/group/bridge_construction/channels/chan_bridge.c 389336 

Diff: https://reviewboard.asterisk.org/r/2551/diff/


Testing
-------

ConfBridge still is able to announce participants and play messages to the bridge.
ConfBridge still is able to record the conference.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130521/3713c583/attachment.htm>