[asterisk-dev] [Code Review] 2546: res_parking: Default Parking Lot

[jrose]

> On May 16, 2013, 2:39 p.m., Paul Belanger wrote:
> > /team/jrose/bridge_projects/res/res_parking.c, line 678
> > <https://reviewboard.asterisk.org/r/2546/diff/1/?file=38112#file38112line678>
> >
> >     Any way we cannot do this?  Always been a peeve of mine, that asterisk defaults to an extension number. Seems to be the only place in asterisk were we do this.
> >     
> >     I'd rather see the user has to explicitly define the extension number vs asterisk just assigning something.
> 
> jrose wrote:
>     Let's take the question to the mailing list.  I don't know the answer for this and I was improvising for maximum backwards compatability.
>     
>     I'll go ahead and say though... it's not like this is forced now.  If you just provide a [default] category in res_confbridge.conf, then this default won't be applied and it will use the regular options. Then if you don't put parkext in [default], it won't even generate extensions at all and you can take complete control of the extensions related to parking (Except for park-dial extensions, those get generated no matter what... I think I might add an option to disable that).

Actually I'm hearing from Matt that having the default use the old behavior when it isn't overridden is the way to go for now. If you want to discuss this further, feel free to get the conversation going.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2546/#review8628
-----------------------------------------------------------


On May 15, 2013, 10:02 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2546/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 10:02 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21643
>     https://issues.asterisk.org/jira/browse/ASTERISK-21643
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Default Parking Lot. Pretty self explanatory. It's a parking lot.  It's named default.  It uses default options.
> 
> Actually, there is one difference between this parking lot and what you would get if you just stuck
> [default]
> 
> in the config file, and that's that if the default parking lot isn't specified in this way, it will set parkext to 700 so that dialplan generation
> will be used and an actual usable parking lot similar to the ones that used to be generated by features.conf will be set up.
> 
> 
> Diffs
> -----
> 
>   /team/jrose/bridge_projects/res/res_parking.c 388603 
> 
> Diff: https://reviewboard.asterisk.org/r/2546/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without the presence of [default] in res_parking.conf
> Tested reloads removing and adding [default]
> Checked memory consumption before and after reloads for both adding and removing default.
> Checked options in the default parking lot created without the presence of [default]
> Checked options in the default parking lot created with the presence of [default]
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130516/26281e1d/attachment-0001.htm>