[asterisk-dev] [Code Review] 2530: Break res_stasis into smaller files

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2530/
-----------------------------------------------------------

(Updated May 14, 2013, 4:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and opticron.


Changes
-------

Committed in revision 388729


Repository: Asterisk


Description
-------

When implementing playback for stasis-http, the monolithicedness of
res_stasis really started to get in my way.

This patch breaks the major components of res_stasis.c into individual
files.

 * res/stasis/app.c - Stasis application tracking
 * res/stasis/control.c - Channel control objects
 * res/stasis/command.c - Channel command object

This refactoring also allows res_stasis applications to be loaded as
independent modules, such as the new res_stasis_answer module.

The bulk of this patch is simply moving code from one file to another,
adjusting names and adding accessors as necessary.


Diffs
-----

  /trunk/apps/app_stasis.c 388370 
  /trunk/include/asterisk/module.h 388370 
  /trunk/include/asterisk/stasis_app.h 388370 
  /trunk/include/asterisk/stasis_app_impl.h PRE-CREATION 
  /trunk/res/Makefile 388370 
  /trunk/res/res_stasis.c 388370 
  /trunk/res/res_stasis_answer.c PRE-CREATION 
  /trunk/res/stasis/app.h PRE-CREATION 
  /trunk/res/stasis/app.c PRE-CREATION 
  /trunk/res/stasis/command.h PRE-CREATION 
  /trunk/res/stasis/command.c PRE-CREATION 
  /trunk/res/stasis/control.h PRE-CREATION 
  /trunk/res/stasis/control.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2530/diff/


Testing
-------

Unit tests


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/53d3e809/attachment.htm>