[asterisk-dev] [Code Review] 2530: Break res_stasis into smaller files

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2530/#review8586
-----------------------------------------------------------

Ship it!


This looks good to go.


/trunk/res/res_stasis.c
<https://reviewboard.asterisk.org/r/2530/#comment16750>

    Extra line snuck in.


- opticron


On May 10, 2013, 12:51 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2530/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 12:51 p.m.)
> 
> 
> Review request for Asterisk Developers and opticron.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When implementing playback for stasis-http, the monolithicedness of
> res_stasis really started to get in my way.
> 
> This patch breaks the major components of res_stasis.c into individual
> files.
> 
>  * res/stasis/app.c - Stasis application tracking
>  * res/stasis/control.c - Channel control objects
>  * res/stasis/command.c - Channel command object
> 
> This refactoring also allows res_stasis applications to be loaded as
> independent modules, such as the new res_stasis_answer module.
> 
> The bulk of this patch is simply moving code from one file to another,
> adjusting names and adding accessors as necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_stasis.c 388370 
>   /trunk/include/asterisk/module.h 388370 
>   /trunk/include/asterisk/stasis_app.h 388370 
>   /trunk/include/asterisk/stasis_app_impl.h PRE-CREATION 
>   /trunk/res/Makefile 388370 
>   /trunk/res/res_stasis.c 388370 
>   /trunk/res/res_stasis_answer.c PRE-CREATION 
>   /trunk/res/stasis/app.h PRE-CREATION 
>   /trunk/res/stasis/app.c PRE-CREATION 
>   /trunk/res/stasis/command.h PRE-CREATION 
>   /trunk/res/stasis/command.c PRE-CREATION 
>   /trunk/res/stasis/control.h PRE-CREATION 
>   /trunk/res/stasis/control.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2530/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/a5c92a0e/attachment.htm>