[asterisk-dev] [Code Review] 2537: Parking: Park and Announce Application

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2537/#review8601
-----------------------------------------------------------



/team/jrose/bridge_projects/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/2537/#comment16778>

    The callerid used for this call needs to be the callerid of the parked call.



/team/jrose/bridge_projects/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/2537/#comment16776>

    Must check data with ast_strlen_zero() and error if the string is NULL or empty.  Like the original application.



/team/jrose/bridge_projects/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/2537/#comment16777>

    You should have error messages for these early exits.
    
    Also you should check that the dial string has a '/' in it or you will crash like the original application will.



/team/jrose/bridge_projects/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/2537/#comment16780>

    This probably should be moved to the bridge push to ensure that all parked channels are answered.



/team/jrose/bridge_projects/res/parking/parking_applications.c
<https://reviewboard.asterisk.org/r/2537/#comment16779>

    Not used.


- rmudgett


On May 14, 2013, 5:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2537/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:53 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: ASTERISK-21352
>     https://issues.asterisk.org/jira/browse/ASTERISK-21352
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Recreate the ParkAndAnnounce application using the new parking system
> 
> 
> Diffs
> -----
> 
>   /team/jrose/bridge_projects/CHANGES 388603 
>   /team/jrose/bridge_projects/UPGRADE.txt 388603 
>   /team/jrose/bridge_projects/apps/app_parkandannounce.c 388603 
>   /team/jrose/bridge_projects/res/parking/parking_applications.c 388603 
>   /team/jrose/bridge_projects/res/parking/res_parking.h 388603 
>   /team/jrose/bridge_projects/res/res_parking.c 388603 
> 
> Diff: https://reviewboard.asterisk.org/r/2537/diff/
> 
> 
> Testing
> -------
> 
> called the following extension with SIP/Gold
> 
> exten => 9600,1,ParkAndAnnounce(testlot1,,tt-weasels:PARKED,SIP/123)
> 
> Made sure parking worked normally and that no memory was leaked from parking/parking_applications.c and that no channels were leaked.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/10427c42/attachment-0001.htm>