[asterisk-dev] [Code Review] 2537: Parking: Park and Announce Application

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2537/#review8599
-----------------------------------------------------------



/team/jrose/bridge_projects/CHANGES
<https://reviewboard.asterisk.org/r/2537/#comment16772>

    It occurs to me that I need to add the following.
    
     * ParkAndAnnounce will no longer go to the next position in dialplan on timeout
       by default. Instead, it will follow the timeout rules of the ParkingLot. The
       old behavior can be reproduced by using the 'c' option.


- jrose


On May 14, 2013, 5:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2537/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 5:53 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: ASTERISK-21352
>     https://issues.asterisk.org/jira/browse/ASTERISK-21352
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Recreate the ParkAndAnnounce application using the new parking system
> 
> 
> Diffs
> -----
> 
>   /team/jrose/bridge_projects/CHANGES 388603 
>   /team/jrose/bridge_projects/UPGRADE.txt 388603 
>   /team/jrose/bridge_projects/apps/app_parkandannounce.c 388603 
>   /team/jrose/bridge_projects/res/parking/parking_applications.c 388603 
>   /team/jrose/bridge_projects/res/parking/res_parking.h 388603 
>   /team/jrose/bridge_projects/res/res_parking.c 388603 
> 
> Diff: https://reviewboard.asterisk.org/r/2537/diff/
> 
> 
> Testing
> -------
> 
> called the following extension with SIP/Gold
> 
> exten => 9600,1,ParkAndAnnounce(testlot1,,tt-weasels:PARKED,SIP/123)
> 
> Made sure parking worked normally and that no memory was leaked from parking/parking_applications.c and that no channels were leaked.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/22fac142/attachment.htm>