[asterisk-dev] [Code Review] 2538: Properly shutdown libsrtp when the functionality is available

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2538/
-----------------------------------------------------------

(Updated May 14, 2013, 2:39 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Richard's comment about unnecessary code.


Bugs: ASTERISK-21719
    https://issues.asterisk.org/jira/browse/ASTERISK-21719


Repository: Asterisk


Description
-------

The srtp_shutdown() function is available on newer versions of libsrtp, but not on older ones (it seems to have been introduced at some point in 1.4.4).  This addition to the build system allows it to be detected and used when available.  The commit will change the configure script, but as usual subversion won't diff it properly since it's considered content-type application/octet-stream.


Diffs (updated)
-----

  branches/1.8/configure UNKNOWN 
  branches/1.8/configure.ac 388688 
  branches/1.8/include/asterisk/autoconfig.h.in 388688 
  branches/1.8/res/res_srtp.c 388688 

Diff: https://reviewboard.asterisk.org/r/2538/diff/


Testing
-------

Ensured that compilation occurred correctly on systems with and without this function.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/b49de5c5/attachment-0001.htm>