[asterisk-dev] [Code Review] 2538: Properly shutdown libsrtp when the functionality is available

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2538/#review8600
-----------------------------------------------------------



branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/2538/#comment16775>

    This code should not be necessary since this is what AST_EXT_LIB_CHECK() should already be doing.


- rmudgett


On May 14, 2013, 7:16 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2538/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 7:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21719
>     https://issues.asterisk.org/jira/browse/ASTERISK-21719
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The srtp_shutdown() function is available on newer versions of libsrtp, but not on older ones (it seems to have been introduced at some point in 1.4.4).  This addition to the build system allows it to be detected and used when available.  The commit will change the configure script, but as usual subversion won't diff it properly since it's considered content-type application/octet-stream.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/configure UNKNOWN 
>   branches/1.8/configure.ac 388688 
>   branches/1.8/include/asterisk/autoconfig.h.in 388688 
>   branches/1.8/res/res_srtp.c 388688 
> 
> Diff: https://reviewboard.asterisk.org/r/2538/diff/
> 
> 
> Testing
> -------
> 
> Ensured that compilation occurred correctly on systems with and without this function.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/f5021d5b/attachment.htm>