[asterisk-dev] [Code Review] 2493: Add WebSocket transport module

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2493/#review8596
-----------------------------------------------------------

Ship it!


Ship It!


/team/group/pimp_my_sip/include/asterisk/res_sip.h
<https://reviewboard.asterisk.org/r/2493/#comment16767>

    Minor nitpick - you can use a zero sized array and allocate this with enough space to hold the URI and not have multiple allocations. Ultimately it'll probably go away, anyway.



/team/group/pimp_my_sip/res/res_sip/location.c
<https://reviewboard.asterisk.org/r/2493/#comment16769>

    Message is incorrect.



/team/group/pimp_my_sip/res/res_sip_transport_websocket.c
<https://reviewboard.asterisk.org/r/2493/#comment16768>

    Check the return values here.


- Joshua Colp


On May 13, 2013, 9:47 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2493/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 9:47 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20952
>     https://issues.asterisk.org/jira/browse/ASTERISK-20952
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds a custom WebSocket transport module.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 388617 
>   /team/group/pimp_my_sip/res/res_sip.c 388617 
>   /team/group/pimp_my_sip/res/res_sip.exports.in 388617 
>   /team/group/pimp_my_sip/res/res_sip/config_transport.c 388617 
>   /team/group/pimp_my_sip/res/res_sip/include/res_sip_private.h 388617 
>   /team/group/pimp_my_sip/res/res_sip/location.c 388617 
>   /team/group/pimp_my_sip/res/res_sip_outbound_registration.c 388617 
>   /team/group/pimp_my_sip/res/res_sip_transport_websocket.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2493/diff/
> 
> 
> Testing
> -------
> 
> Registration works, incoming (from the browser) and outgoing (to the browser) calls work, audio flows (though, I don't have a mic, so I didn't test audio that direction).
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130514/871b1d6c/attachment.htm>