[asterisk-dev] [Code Review] 2493: Add WebSocket transport module

[Jason Parker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2493/
-----------------------------------------------------------

(Updated May 13, 2013, 9:47 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address all the feedback.

There's an issue that I've been discussing with Josh, which occurs with some clients (*ahem*), where the contact URI won't be unique, even from different systems.  Solving that requires a bit of re-architecturing elsewhere, and won't be addressed here.


Bugs: ASTERISK-20952
    https://issues.asterisk.org/jira/browse/ASTERISK-20952


Repository: Asterisk


Description
-------

Adds a custom WebSocket transport module.


Diffs (updated)
-----

  /team/group/pimp_my_sip/include/asterisk/res_sip.h 388617 
  /team/group/pimp_my_sip/res/res_sip.c 388617 
  /team/group/pimp_my_sip/res/res_sip.exports.in 388617 
  /team/group/pimp_my_sip/res/res_sip/config_transport.c 388617 
  /team/group/pimp_my_sip/res/res_sip/include/res_sip_private.h 388617 
  /team/group/pimp_my_sip/res/res_sip/location.c 388617 
  /team/group/pimp_my_sip/res/res_sip_outbound_registration.c 388617 
  /team/group/pimp_my_sip/res/res_sip_transport_websocket.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2493/diff/


Testing
-------

Registration works, incoming (from the browser) and outgoing (to the browser) calls work, audio flows (though, I don't have a mic, so I didn't test audio that direction).


Thanks,

Jason Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/81712cbf/attachment.htm>