[asterisk-dev] [Code Review] 2510: Stasis: Update confbridge events.

[jrose]

> On May 9, 2013, 4:14 p.m., opticron wrote:
> > /team/group/bridge_construction/apps/app_confbridge.c, lines 424-425
> > <https://reviewboard.asterisk.org/r/2510/diff/1/?file=37433#file37433line424>
> >
> >     The tabbing here seems a tad excessive.

It actually lines up really nicely with 4-space tabs, but yeah, I see your point. Tabbyness decreased!


> On May 9, 2013, 4:14 p.m., opticron wrote:
> > /team/group/bridge_construction/apps/app_confbridge.c, lines 444-445
> > <https://reviewboard.asterisk.org/r/2510/diff/1/?file=37433#file37433line444>
> >
> >     You may also want to send this message to the bridge topic if channel is non-NULL.

Just talked about this with Matt and David.  For now we aren't going to publish messages to multiple topics. What I will do for this is the following though:

Mute/unmute - channel topic
Enter/leave/talking - bridge topic


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2510/#review8547
-----------------------------------------------------------


On May 8, 2013, 4:46 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2510/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 4:46 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21468
>     https://issues.asterisk.org/jira/browse/ASTERISK-21468
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Not a whole ton to say about this one.  More manager event stuff being turned into stasis stuff. This does push out some bridge blob messages over the channel topic, which I suppose might be slightly interesting.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/apps/app_confbridge.c 387849 
>   /team/group/bridge_construction/apps/confbridge/confbridge_manager.c PRE-CREATION 
>   /team/group/bridge_construction/apps/confbridge/include/confbridge.h 387849 
> 
> Diff: https://reviewboard.asterisk.org/r/2510/diff/
> 
> 
> Testing
> -------
> 
> Made sure each event would be issued to manager through with all the appropriate bridge/channels snapshot information and expected fields.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130513/e4ee9185/attachment.htm>