[asterisk-dev] [Code Review] 2510: Stasis: Update confbridge events.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2510/#review8547
-----------------------------------------------------------



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2510/#comment16528>

    The tabbing here seems a tad excessive.



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2510/#comment16529>

    You may also want to send this message to the bridge topic if channel is non-NULL.



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2510/#comment16530>

    Change this to send_conf_start_event for consistency.



/team/group/bridge_construction/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/2510/#comment16531>

    Adjacent red blob.


- opticron


On May 8, 2013, 11:46 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2510/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 11:46 a.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21468
>     https://issues.asterisk.org/jira/browse/ASTERISK-21468
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Not a whole ton to say about this one.  More manager event stuff being turned into stasis stuff. This does push out some bridge blob messages over the channel topic, which I suppose might be slightly interesting.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/apps/app_confbridge.c 387849 
>   /team/group/bridge_construction/apps/confbridge/confbridge_manager.c PRE-CREATION 
>   /team/group/bridge_construction/apps/confbridge/include/confbridge.h 387849 
> 
> Diff: https://reviewboard.asterisk.org/r/2510/diff/
> 
> 
> Testing
> -------
> 
> Made sure each event would be issued to manager through with all the appropriate bridge/channels snapshot information and expected fields.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130509/75ef3242/attachment.htm>