[asterisk-dev] [Code Review] 2482: Add tests for SDP SRTP negotiation
Paul Belanger
reviewboard at asterisk.org
Wed May 8 10:44:46 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2482/#review8500
-----------------------------------------------------------
asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/2482/#comment16400>
something wrong with the style, extra tabs I guess
- Paul Belanger
On May 6, 2013, 6:13 p.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2482/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:13 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-21416
> https://issues.asterisk.org/jira/browse/ASTERISK-21416
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> Add tests for SRTP negotiation in SDP for cases where:
> * Call declined
> ** Encryption enabled
> *** Unknown cryptographic suite in offer
> *** Missing crypto attribute in offer
> *** Encryption not offered (attribute present)
> *** Missing key
> *** Missing tag
> *** Missing suite
> *** Lifetime present
> ** Encryption not enabled
> * Call accepted
> ** Encryption not enabled, crypto attribute present and ignored
> ** Encryption enabled
> *** Nominal, single attribute line
> *** Nominal, multiple attribute lines with the first offer being unacceptable
>
> Requires the patch in review: https://reviewboard.asterisk.org/r/2503/
>
>
> Diffs
> -----
>
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/extensions.conf PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/res_sip.conf PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_disabled_with_attrib.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_multiple_attrib_first_bad.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_nominal.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_enabled.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_attrib.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_key.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_suite.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_tag.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_not_enabled.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_unknown_suite.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_with_lifetime.xml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/test-config.yaml PRE-CREATION
> asterisk/team/group/pimp_my_sip/tests/channels/gulp/tests.yaml 3735
>
> Diff: https://reviewboard.asterisk.org/r/2482/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/604a15b2/attachment-0001.htm>
More information about the asterisk-dev
mailing list