<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2482/">https://reviewboard.asterisk.org/r/2482/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2482/diff/4/?file=37216#file37216line3" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/extensions.conf</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">same  =&gt;      n,Echo()</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">something wrong with the style, extra tabs I guess</pre>
</div>
<br />



<p>- Paul</p>


<br />
<p>On May 6th, 2013, 6:13 p.m. UTC, opticron wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated May 6, 2013, 6:13 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21416">ASTERISK-21416</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add tests for SRTP negotiation in SDP for cases where:
* Call declined
** Encryption enabled
*** Unknown cryptographic suite in offer
*** Missing crypto attribute in offer
*** Encryption not offered (attribute present)
*** Missing key
*** Missing tag
*** Missing suite
*** Lifetime present
** Encryption not enabled
* Call accepted
** Encryption not enabled, crypto attribute present and ignored
** Encryption enabled
*** Nominal, single attribute line
*** Nominal, multiple attribute lines with the first offer being unacceptable

Requires the patch in review: https://reviewboard.asterisk.org/r/2503/</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/configs/ast1/res_sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_disabled_with_attrib.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_multiple_attrib_first_bad.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/accept_nominal.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_enabled.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_attrib.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_key.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_suite.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_no_tag.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_not_enabled.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_unknown_suite.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/sipp/decline_with_lifetime.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/srtp_negotiation/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/team/group/pimp_my_sip/tests/channels/gulp/tests.yaml <span style="color: grey">(3735)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2482/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>