[asterisk-dev] [Code Review] 2475: NOTIFYs for BLF start queuing up and fail to be sent out after retries fail

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2475/#review8480
-----------------------------------------------------------

Ship it!


Committed, to fix current issue where asterisk is obviously broken, if a response isn't received.

Another review should be opened if we want to allow a few notify to fail, covering Walter's concerns.

- Alec Davis


On May 8, 2013, 7:17 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2475/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 7:17 a.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Bugs: ASTERISK-21677
>     https://issues.asterisk.org/jira/browse/ASTERISK-21677
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The notify subsystem relies on a NOTIFY 200OK response to clear the SIP_PAGE2_STATECHANGEQUEUE flag and p->pendinginvite.
> If the response never arrives, then any further NOTIFYs cannot EVER be sent, they just 'queue' up by replacing the previous queued notify.
> 
> The fix: Follow RFC6665 4.2.2 more closely, after failed NOTIFY transaction remove the subscription.
> Then after a period of time the client will (re-)subscribe, which will create a new subscription.
> 
> For minimum BLF 'not working' time maxexpiry in sip.conf needs to be around 300, not the default of 3600 seconds.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 380212 
> 
> Diff: https://reviewboard.asterisk.org/r/2475/diff/
> 
> 
> Testing
> -------
> 
> As per bug report  https://issues.asterisk.org/jira/browse/ASTERISK-21677
> 
> Asterisk 1.8, subscribers will NOT update their status when they re-subscribe, but will on the next event.
> Asterisk 11, subscribers WILL update their status when they re-subscribes.
> 
> 
> Reporter of ASTERISK-21677 has also tested on a number of production servers.
> 
> 
> Thanks,
> 
> Alec Davis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130508/28cc294f/attachment-0001.htm>