[asterisk-dev] [Code Review] 2507: Add support for indexing installed sounds and for Stasis-HTTP sounds queries
opticron
reviewboard at asterisk.org
Tue May 7 09:16:49 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2507/
-----------------------------------------------------------
Review request for Asterisk Developers and David Lee.
Bugs: ASTERISK-21584 and ASTERISK-21585
https://issues.asterisk.org/jira/browse/ASTERISK-21584
https://issues.asterisk.org/jira/browse/ASTERISK-21585
Repository: Asterisk
Description
-------
This adds support for stasis/sounds and stasis/sounds/{ID} queries via the Stasis-HTTP interface.
The following changes have been made to accomplish this:
* A modular indexer was created for local sound files.
* A new function to get an ast_format associated with a file extension was added.
* Modifications were made to the built-in HTTP server so that URI decoding could be deferred to the URI handler when necessary.
* The Stasis-HTTP sounds JSON documentation was modified to handle cases where multiple languages are installed in different formats.
This requires the additions to astobj2.c/h present in https://reviewboard.asterisk.org/r/2428/
Diffs
-----
/trunk/main/sounds.c PRE-CREATION
/trunk/main/http.c 387798
/trunk/main/file.c 387798
/trunk/include/asterisk/sounds.h PRE-CREATION
/trunk/include/asterisk/http.h 387798
/trunk/include/asterisk/file.h 387798
/trunk/res/res_sounds.c PRE-CREATION
/trunk/res/res_stasis_http.c 387798
/trunk/res/stasis_http/resource_sounds.h 387798
/trunk/res/stasis_http/resource_sounds.c 387798
/trunk/rest-api/api-docs/sounds.json 387798
Diff: https://reviewboard.asterisk.org/r/2507/diff/
Testing
-------
Tested using a browser and HTTP GET requests using the Stasis-HTTP API. Currently contemplating how to create automated tests.
Thanks,
opticron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/d88b92cd/attachment-0001.htm>
More information about the asterisk-dev
mailing list