[asterisk-dev] [Code Review] 2494: Add multi-channel blob message type; refactor ChanSpyStart/ChanSpyStop events to use it

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2494/
-----------------------------------------------------------

(Updated May 7, 2013, 1:56 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed ref leak of channel snapshot


Bugs: ASTERISK-21462
    https://issues.asterisk.org/jira/browse/ASTERISK-21462


Repository: Asterisk


Description
-------

Multi-channel blob messages were added awhile back for Dial; however, the multi-channel blob is used by Dial not as a message type but rather as a payload. This patch gives multi-channel blobs their own generic message type for the random kinds of things we're going to need to use it for (ChanSpy being the first candidate).

I've left Dial alone even though its payload now has its own generic message type. Dial messages have a significant number of producers and consumers, in a variety of modules. (app_dial, app_queue, app_followme, pbx, cdr, manager_channels, etc. - the list will grow) It feels important enough that having its own message type is useful and avoids the extra step of parsing out the JSON 'type' field.


Diffs (updated)
-----

  /trunk/main/stasis_channels.c 387797 
  /trunk/main/manager_channels.c 387797 
  /trunk/include/asterisk/stasis_channels.h 387797 
  /trunk/include/asterisk/manager.h 387797 
  /trunk/include/asterisk/autoconfig.h.in 387797 
  /trunk/apps/app_chanspy.c 387797 
  /trunk/configure UNKNOWN 

Diff: https://reviewboard.asterisk.org/r/2494/diff/


Testing
-------

ChanSpy tests pass (once I remembered to install chan_console... ew)


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/2e1c9259/attachment-0001.htm>