[asterisk-dev] [Code Review] 2494: Add multi-channel blob message type; refactor ChanSpyStart/ChanSpyStop events to use it

[Matt Jordan]

> On May 7, 2013, 1:23 p.m., David Lee wrote:
> > /trunk/apps/app_chanspy.c, line 524
> > <https://reviewboard.asterisk.org/r/2494/diff/2/?file=37258#file37258line524>
> >
> >     Memory leak. Use a RAII_VAR().

Whoops, I forgot that adding the snapshot to a multi-channel message bumps the ref count as well. Thanks!


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2494/#review8462
-----------------------------------------------------------


On May 6, 2013, 10:48 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2494/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 10:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21462
>     https://issues.asterisk.org/jira/browse/ASTERISK-21462
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Multi-channel blob messages were added awhile back for Dial; however, the multi-channel blob is used by Dial not as a message type but rather as a payload. This patch gives multi-channel blobs their own generic message type for the random kinds of things we're going to need to use it for (ChanSpy being the first candidate).
> 
> I've left Dial alone even though its payload now has its own generic message type. Dial messages have a significant number of producers and consumers, in a variety of modules. (app_dial, app_queue, app_followme, pbx, cdr, manager_channels, etc. - the list will grow) It feels important enough that having its own message type is useful and avoids the extra step of parsing out the JSON 'type' field.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_chanspy.c 387741 
>   /trunk/include/asterisk/manager.h 387741 
>   /trunk/include/asterisk/stasis_channels.h 387741 
>   /trunk/main/manager_channels.c 387741 
>   /trunk/main/stasis_channels.c 387741 
> 
> Diff: https://reviewboard.asterisk.org/r/2494/diff/
> 
> 
> Testing
> -------
> 
> ChanSpy tests pass (once I remembered to install chan_console... ew)
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130507/1820a897/attachment.htm>