[asterisk-dev] [Code Review] 2497: Add MWI events to AMI over Stasis-Core

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2497/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-21462
    https://issues.asterisk.org/jira/browse/ASTERISK-21462


Repository: Asterisk


Description
-------

This patch does the following:

 * Refactors the name of our MWI topics/message types to be prefixed with ast_. This was done to keep the naming conventions consistent with channel objects moving through Stasis.
 * Adds a blob type for MWI messages, and a blob message type
 * Adds a channel snapshot to the ast_mwi_state object. This is optional, but a lot of times AMI needs to know what channel just changed the MWI state. This is actually really useful, as it enables consumers of MWI state to know the channel that is manipulating the voicemail mailbox (as an exercise for the reader, come up with awesome features based on this...)
 * Refactors the one existing MiniVoiceMail event to use the MWI + JSON blob. While this is a bit overkill, if someone took app_minivm and ran with it, this would be a useful addition (and app_voicemail or other voicemail related applications would want the JSON).

Note that documentation for shared VM events is done in manager_mwi.c, while documentation for AMI events that are only raised by a single application are documented in the source file of the application that raises those events (even if the formatting is still done in manager_mwi.c).


Diffs
-----

  trunk/apps/app_minivm.c 387611 
  trunk/apps/app_voicemail.c 387611 
  trunk/channels/chan_dahdi.c 387611 
  trunk/channels/chan_iax2.c 387611 
  trunk/channels/chan_mgcp.c 387611 
  trunk/channels/chan_sip.c 387611 
  trunk/channels/chan_skinny.c 387611 
  trunk/channels/chan_unistim.c 387611 
  trunk/channels/sig_pri.c 387611 
  trunk/include/asterisk/app.h 387611 
  trunk/include/asterisk/manager.h 387611 
  trunk/main/app.c 387611 
  trunk/main/manager.c 387611 
  trunk/main/manager_mwi.c PRE-CREATION 
  trunk/res/res_jabber.c 387611 
  trunk/res/res_sip_mwi.c 387611 
  trunk/res/res_xmpp.c 387611 

Diff: https://reviewboard.asterisk.org/r/2497/diff/


Testing
-------

Ran the voicemail Test Suite tests. Checked logs; saw events; rejoiced.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130503/a9bada95/attachment.htm>