[asterisk-dev] [Code Review] 2428: Add channel event distribution to app_stasis

[opticron]

> On May 2, 2013, 4:27 p.m., David Lee wrote:
> > trunk/rest-api/api-docs/events.json, lines 57-59
> > <https://reviewboard.asterisk.org/r/2428/diff/8/?file=36792#file36792line57>
> >
> >     You lost the bridge events there.

These were dropped intentionally for the trunk patch since the things they depend on only exist in bridge_construction at the moment.


> On May 2, 2013, 4:27 p.m., David Lee wrote:
> > trunk/rest-api-templates/swagger_model.py, line 298
> > <https://reviewboard.asterisk.org/r/2428/diff/8/?file=36791#file36791line298>
> >
> >     This should be self.description instead of self.notes.

There is also a notes field that is used in a few of the event models.  I'll make sure both are there.


> On May 2, 2013, 4:27 p.m., David Lee wrote:
> > trunk/rest-api/api-docs/events.json, lines 213-217
> > <https://reviewboard.asterisk.org/r/2428/diff/8/?file=36792#file36792line213>
> >
> >     This is especially weird, since the body is a "name: value\r\n" formatted string. Maybe we can be a little bit nicer and parse the provided user data into a JSON object? Thoughts?

What do you think about Userevent publishing it in JSON format and then it being converted to other formats by the consumers? (I already have this code floating around in another branch)


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2428/#review8442
-----------------------------------------------------------


On April 30, 2013, 9:03 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2428/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 9:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21180
>     https://issues.asterisk.org/jira/browse/ASTERISK-21180
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add publication of AMI-equivalent channel event messages to users of app_stasis using JSON blobs.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/astobj2.h 386934 
>   trunk/include/asterisk/stasis_channels.h 386934 
>   trunk/main/astobj2.c 386934 
>   trunk/main/manager_channels.c 386934 
>   trunk/main/stasis_channels.c 386934 
>   trunk/res/res_stasis.c 386934 
>   trunk/res/res_stasis_http_events.c 386934 
>   trunk/res/res_stasis_websocket.c 386934 
>   trunk/res/stasis_http/resource_events.h 386934 
>   trunk/res/stasis_http/resource_recordings.h 386934 
>   trunk/res/stasis_http/resource_sounds.h 386934 
>   trunk/rest-api-templates/asterisk_processor.py 386934 
>   trunk/rest-api-templates/event_function_decl.mustache PRE-CREATION 
>   trunk/rest-api-templates/res_stasis_http_resource.c.mustache 386934 
>   trunk/rest-api-templates/stasis_http_resource.h.mustache 386934 
>   trunk/rest-api-templates/swagger_model.py 386934 
>   trunk/rest-api/api-docs/events.json 386934 
> 
> Diff: https://reviewboard.asterisk.org/r/2428/diff/
> 
> 
> Testing
> -------
> 
> Tested with a hacked together app_stasis app which dumps incoming messages.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130503/6fecb492/attachment-0001.htm>