[asterisk-dev] [Code Review] 2491: Pull utils/refcounter into Asterisk

[Russell Bryant]

> On May 2, 2013, 7:42 p.m., Mark Michelson wrote:
> > I don't think this belongs inside Asterisk.
> > 
> > The majority of the time that people would want to run the refcounter utility is after Asterisk finishes running so they can see the final refcounts of objects to make sure that during the run, everything went smoothly. This is especially useful if there was a crash due to a refcount issue.
> 
> Jason Parker wrote:
>     The usage, as I imagined it, would be to move the /tmp/refs file after Asterisk has stopped, and point the CLI command at that on a future execution.
> 
> Mark Michelson wrote:
>     That's hella awkward.

I think the solution to the ugly utils thing is that parts of Asterisk should be consumable as libraries, as opposed to being limited to only within the Asterisk daemon itself.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2491/#review8433
-----------------------------------------------------------


On May 2, 2013, 9:09 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2491/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 9:09 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The utils/ directory needs a whole lot of love.  Many of the utilities use copies of Asterisk source.  In many cases, the copies are in other files, and are extremely out of date.  This is a start towards fixing that.
> 
> Adds a CLI command, astobj2 refcount <filename>, which does what refcounter used to.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/astobj2.c 387415 
>   /trunk/utils/Makefile 387415 
>   /trunk/utils/refcounter.c 387415 
>   /trunk/utils/utils.xml 387415 
> 
> Diff: https://reviewboard.asterisk.org/r/2491/diff/
> 
> 
> Testing
> -------
> 
> I'm not familiar with how the output of this should really look.  It gives me some output though, and it looks pretty reasonable.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130502/6b7db83a/attachment.htm>