<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2491/">https://reviewboard.asterisk.org/r/2491/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 2nd, 2013, 7:42 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this belongs inside Asterisk.
The majority of the time that people would want to run the refcounter utility is after Asterisk finishes running so they can see the final refcounts of objects to make sure that during the run, everything went smoothly. This is especially useful if there was a crash due to a refcount issue.</pre>
</blockquote>
<p>On May 2nd, 2013, 7:49 p.m. UTC, <b>Jason Parker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The usage, as I imagined it, would be to move the /tmp/refs file after Asterisk has stopped, and point the CLI command at that on a future execution.</pre>
</blockquote>
<p>On May 2nd, 2013, 7:54 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's hella awkward.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the solution to the ugly utils thing is that parts of Asterisk should be consumable as libraries, as opposed to being limited to only within the Asterisk daemon itself.</pre>
<br />
<p>- Russell</p>
<br />
<p>On May 2nd, 2013, 9:09 p.m. UTC, Jason Parker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated May 2, 2013, 9:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The utils/ directory needs a whole lot of love. Many of the utilities use copies of Asterisk source. In many cases, the copies are in other files, and are extremely out of date. This is a start towards fixing that.
Adds a CLI command, astobj2 refcount <filename>, which does what refcounter used to.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not familiar with how the output of this should really look. It gives me some output though, and it looks pretty reasonable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/astobj2.c <span style="color: grey">(387415)</span></li>
<li>/trunk/utils/Makefile <span style="color: grey">(387415)</span></li>
<li>/trunk/utils/refcounter.c <span style="color: grey">(387415)</span></li>
<li>/trunk/utils/utils.xml <span style="color: grey">(387415)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2491/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>