[asterisk-dev] [Code Review] testsuite: shorten /tmp/asterisk-testsuite paths so the limited AF_UNIX path size isn't a problem

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2399/#review8094
-----------------------------------------------------------

Ship it!


- Matt


On March 18, 2013, 8:18 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2399/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 8:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> AF_UNIX paths are limited to around 108 characters. A few more bytes seem to fit, but not many.
> 
> This socket was creatable:
> 
>   /tmp/asterisk-testsuite/channels/SIP/session_timers/uas_originate/no_minse_no_se/ast1/var/run/asterisk/asterisk.ctl
> 
> This wasn't:
> 
>   /tmp/asterisk-testsuite/channels/SIP/session_timers/uas_originate/no_minse_medium_se/ast1/var/run/asterisk/asterisk.ctl
> 
> I patched the test-suite so the new path is:
> 
>   /tmp/asterisk-testsuite/67c2adc4bfa8c84650abfd3774a32cd6/ast1/var/run/asterisk/asterisk.ctl
> 
>   (md5('channels/SIP/session_timers/uas_originate/no_minse_medium_se') == '67c2adc4bfa8c84650abfd3774a32cd6')
> 
> 
> To make finding the right path easy, I added symlinks from the original name to the new name.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/TestCase.py 3668 
> 
> Diff: https://reviewboard.asterisk.org/r/2399/diff
> 
> 
> Testing
> -------
> 
> The SIP tests ran, with the same amount of success as before, but again quicker because teardown worked properly for all tests this time.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/6936af74/attachment.htm>