<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2399/">https://reviewboard.asterisk.org/r/2399/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Matt</p>
<br />
<p>On March 18th, 2013, 8:18 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 8:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AF_UNIX paths are limited to around 108 characters. A few more bytes seem to fit, but not many.
This socket was creatable:
/tmp/asterisk-testsuite/channels/SIP/session_timers/uas_originate/no_minse_no_se/ast1/var/run/asterisk/asterisk.ctl
This wasn't:
/tmp/asterisk-testsuite/channels/SIP/session_timers/uas_originate/no_minse_medium_se/ast1/var/run/asterisk/asterisk.ctl
I patched the test-suite so the new path is:
/tmp/asterisk-testsuite/67c2adc4bfa8c84650abfd3774a32cd6/ast1/var/run/asterisk/asterisk.ctl
(md5('channels/SIP/session_timers/uas_originate/no_minse_medium_se') == '67c2adc4bfa8c84650abfd3774a32cd6')
To make finding the right path easy, I added symlinks from the original name to the new name.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The SIP tests ran, with the same amount of success as before, but again quicker because teardown worked properly for all tests this time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(3668)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2399/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>