[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/#review8987
-----------------------------------------------------------

Ship it!


I couldn't find anything problematic with what you have, so I'm giving my stamp of approval. Obviously, it would be best if you let Richard have another go at it because he may know of situations where COLP updates are needed where they aren't addressed here.


/trunk/main/bridging.c
<https://reviewboard.asterisk.org/r/2636/#comment17681>

    You can replace the ternary logic with !optimized


- Mark Michelson


On June 26, 2013, 5:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 5:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21829
>     https://issues.asterisk.org/jira/browse/ASTERISK-21829
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).
> 
> Old code which is no longer required has also been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 392646 
>   /trunk/main/bridging.c 392646 
>   /trunk/main/channel.c 392646 
> 
> Diff: https://reviewboard.asterisk.org/r/2636/diff/
> 
> 
> Testing
> -------
> 
> Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).
> 
> Calling, transfers, etc.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/037f3521/attachment.htm>