[asterisk-dev] [Code Review] 2612: REST API - channel recording support

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2612/
-----------------------------------------------------------

(Updated June 27, 2013, 10:52 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed comment and oops


Bugs: ASTERISK-21594
    https://issues.asterisk.org/jira/browse/ASTERISK-21594


Repository: Asterisk


Description
-------

This patch is the first step in adding recording support to the
Asterisk REST Interface.

Recordings are stored in /var/spool/recording. Since recordings may be
destructive (overwriting existing files), the API rejects attempts to
escape the recording directory (avoiding issues if someone attempts to
record to ../../lib/sounds/greeting, for example).


Diffs (updated)
-----

  /trunk/Makefile 392772 
  /trunk/apps/app_minivm.c 392772 
  /trunk/apps/app_voicemail.c 392772 
  /trunk/include/asterisk/app.h 392772 
  /trunk/include/asterisk/channel.h 392772 
  /trunk/include/asterisk/file.h 392772 
  /trunk/include/asterisk/paths.h 392772 
  /trunk/include/asterisk/stasis_app_recording.h PRE-CREATION 
  /trunk/include/asterisk/utils.h 392772 
  /trunk/main/app.c 392772 
  /trunk/main/asterisk.c 392772 
  /trunk/main/channel.c 392772 
  /trunk/main/file.c 392772 
  /trunk/main/utils.c 392772 
  /trunk/res/res_stasis_http_bridges.c 392772 
  /trunk/res/res_stasis_http_channels.c 392772 
  /trunk/res/res_stasis_http_recordings.c 392772 
  /trunk/res/res_stasis_playback.c 392772 
  /trunk/res/res_stasis_recording.c PRE-CREATION 
  /trunk/res/res_stasis_recording.exports.in PRE-CREATION 
  /trunk/res/stasis_http/resource_channels.h 392772 
  /trunk/res/stasis_http/resource_channels.c 392772 
  /trunk/res/stasis_http/resource_recordings.h 392772 
  /trunk/res/stasis_http/resource_recordings.c 392772 
  /trunk/res/stasis_json/resource_sounds.h 392772 
  /trunk/rest-api-templates/asterisk_processor.py 392772 
  /trunk/rest-api-templates/swagger_model.py 392772 
  /trunk/rest-api/api-docs/channels.json 392772 
  /trunk/rest-api/api-docs/recordings.json 392772 
  /trunk/tests/test_utils.c 392772 

Diff: https://reviewboard.asterisk.org/r/2612/diff/


Testing
-------

Unit tests; swagger-ui for manual testing


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/06987c1d/attachment.htm>