<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2612/">https://reviewboard.asterisk.org/r/2612/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 10:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed comment and oops</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21594">ASTERISK-21594</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the first step in adding recording support to the
Asterisk REST Interface.
Recordings are stored in /var/spool/recording. Since recordings may be
destructive (overwriting existing files), the API rejects attempts to
escape the recording directory (avoiding issues if someone attempts to
record to ../../lib/sounds/greeting, for example).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests; swagger-ui for manual testing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/Makefile <span style="color: grey">(392772)</span></li>
<li>/trunk/apps/app_minivm.c <span style="color: grey">(392772)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(392772)</span></li>
<li>/trunk/include/asterisk/app.h <span style="color: grey">(392772)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(392772)</span></li>
<li>/trunk/include/asterisk/file.h <span style="color: grey">(392772)</span></li>
<li>/trunk/include/asterisk/paths.h <span style="color: grey">(392772)</span></li>
<li>/trunk/include/asterisk/stasis_app_recording.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/utils.h <span style="color: grey">(392772)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(392772)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(392772)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(392772)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(392772)</span></li>
<li>/trunk/main/utils.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/res_stasis_http_bridges.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/res_stasis_http_channels.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/res_stasis_http_recordings.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/res_stasis_playback.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/res_stasis_recording.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_stasis_recording.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/stasis_http/resource_channels.h <span style="color: grey">(392772)</span></li>
<li>/trunk/res/stasis_http/resource_channels.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/stasis_http/resource_recordings.h <span style="color: grey">(392772)</span></li>
<li>/trunk/res/stasis_http/resource_recordings.c <span style="color: grey">(392772)</span></li>
<li>/trunk/res/stasis_json/resource_sounds.h <span style="color: grey">(392772)</span></li>
<li>/trunk/rest-api-templates/asterisk_processor.py <span style="color: grey">(392772)</span></li>
<li>/trunk/rest-api-templates/swagger_model.py <span style="color: grey">(392772)</span></li>
<li>/trunk/rest-api/api-docs/channels.json <span style="color: grey">(392772)</span></li>
<li>/trunk/rest-api/api-docs/recordings.json <span style="color: grey">(392772)</span></li>
<li>/trunk/tests/test_utils.c <span style="color: grey">(392772)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2612/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>