[asterisk-dev] [Code Review] 2581: astobj2-ify the SLA code.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2581/#review8895
-----------------------------------------------------------


I've now looked at this several times, and I really can't find much other than the nitpicks below. This scares me slightly :-)

It'd be nice if someone else could take a look at this before it goes in, particularly given its scope. If no one pokes it this week, I'll click the old Ship It!.


/branches/1.8/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2581/#comment17460>

    Nitpick: everywhere you have an ao2_ref(foo, -1) you could just use your unref_obj helper function.



/branches/1.8/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2581/#comment17605>

    When you merge up to 11, just make sure you replace all of the unref_obj with ao2_cleanup



/branches/1.8/include/asterisk/utils.h
<https://reviewboard.asterisk.org/r/2581/#comment17604>

    Technically, it is now \since 1.8.24.0


- Matt Jordan


On June 11, 2013, 12:17 a.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2581/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 12:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The SLA code within app_meetme was written before asotbj2 had been
> merged into Asterisk.  Worse, support for reloads did not exist at first
> and was added later as a bolt-on feature.  I knew at the time that
> reloading was not safe at all while SLA was in use, so the reload would
> be queued up to execute when the system was idle.  Unfortunately, this
> approach was still prone to errors beyond the fact that this was the
> only place in Asterisk where configuration was not reloaded
> instantly when requested.
> 
> This patch converts various SLA objects to be reference counted objects
> using astobj2.  This allows reloads to be processed while the system is
> in use.  The code ensures that the objects will not disappear while one
> of the other threads is using them.  However, they will be immediately
> removed from the global trunk and station containers so no new calls
> will use them if removed from configuration.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_meetme.c 391331 
>   /branches/1.8/configs/sla.conf.sample 391331 
>   /branches/1.8/include/asterisk/utils.h 391331 
> 
> Diff: https://reviewboard.asterisk.org/r/2581/diff/
> 
> 
> Testing
> -------
> 
> Manual configuration related testing by me.  Functional testing by CoreDial, LLC.
> 
> 
> Thanks,
> 
> Russell Bryant
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130624/bd5ace95/attachment.htm>