[asterisk-dev] [Code Review] 2581: astobj2-ify the SLA code.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2581/
-----------------------------------------------------------

(Updated June 11, 2013, 12:17 a.m.)


Review request for Asterisk Developers.


Changes
-------

rebase patch for latest 1.8 branch


Repository: Asterisk


Description
-------

The SLA code within app_meetme was written before asotbj2 had been
merged into Asterisk.  Worse, support for reloads did not exist at first
and was added later as a bolt-on feature.  I knew at the time that
reloading was not safe at all while SLA was in use, so the reload would
be queued up to execute when the system was idle.  Unfortunately, this
approach was still prone to errors beyond the fact that this was the
only place in Asterisk where configuration was not reloaded
instantly when requested.

This patch converts various SLA objects to be reference counted objects
using astobj2.  This allows reloads to be processed while the system is
in use.  The code ensures that the objects will not disappear while one
of the other threads is using them.  However, they will be immediately
removed from the global trunk and station containers so no new calls
will use them if removed from configuration.


Diffs (updated)
-----

  /branches/1.8/apps/app_meetme.c 391331 
  /branches/1.8/configs/sla.conf.sample 391331 
  /branches/1.8/include/asterisk/utils.h 391331 

Diff: https://reviewboard.asterisk.org/r/2581/diff/


Testing
-------

Manual configuration related testing by me.  Functional testing by CoreDial, LLC.


Thanks,

Russell Bryant

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130611/18efaa6c/attachment-0001.htm>