[asterisk-dev] [Code Review] 2586: Refactor app_queue AMI events into stasis.

Jason Parker reviewboard at asterisk.org
Fri Jun 7 11:21:10 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2586/
-----------------------------------------------------------

(Updated June 7, 2013, 4:21 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address review feedback.


Bugs: ASTERISK-21469
    https://issues.asterisk.org/jira/browse/ASTERISK-21469


Repository: Asterisk


Description
-------

Move app_queue AMI events to stasis.

Also removes eventwhencalled and eventmemberstatus, since it doesn't make sense (to me...) to keep them.

Renames Join/Leave to QueueCallerJoin/QueueCallerLeave.

Standardize many of the events, such as settling on a single way of displaying Interface/Location/Member/Whatever, and using channel snapshots where necessary.


Diffs (updated)
-----

  /trunk/main/manager.c 390854 
  /trunk/configs/queues.conf.sample 390854 
  /trunk/apps/app_queue.c 390854 
  /trunk/CHANGES 390854 

Diff: https://reviewboard.asterisk.org/r/2586/diff/


Testing
-------

All of the events come out in the order they're supposed to.


Thanks,

Jason Parker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130607/8878ca7e/attachment-0001.htm>


More information about the asterisk-dev mailing list