[asterisk-dev] [Code Review] 2586: Refactor app_queue AMI events into stasis.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2586/#review8845
-----------------------------------------------------------



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2586/#comment17397>

    These XML event definitions need to include the default set of channel snapshot parameters.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2586/#comment17390>

    This is a duplication of ast_channel_publish_blob.


The default set of channel snapshot parameters the the set of Dest channel snapshot parameters also need to be included in the multi-channel blob events. The set of channel parameters prefixed with Dest already exists and does not need to be created.

- opticron


On June 5, 2013, 10:41 a.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2586/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 10:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21469
>     https://issues.asterisk.org/jira/browse/ASTERISK-21469
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Move app_queue AMI events to stasis.
> 
> Also removes eventwhencalled and eventmemberstatus, since it doesn't make sense (to me...) to keep them.
> 
> Renames Join/Leave to QueueCallerJoin/QueueCallerLeave.
> 
> Standardize many of the events, such as settling on a single way of displaying Interface/Location/Member/Whatever, and using channel snapshots where necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 390386 
>   /trunk/apps/app_queue.c 390386 
>   /trunk/configs/queues.conf.sample 390386 
>   /trunk/main/manager.c 390386 
> 
> Diff: https://reviewboard.asterisk.org/r/2586/diff/
> 
> 
> Testing
> -------
> 
> All of the events come out in the order they're supposed to.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/59fa7502/attachment-0001.htm>